Fix reference to undefined device object in appinfo#90
Merged
Conversation
Member
|
Thanks for spotting this! Yes, that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This currently causes the CI app tests for the BangleApps repo to essentially just always return fine since no tests are actually run. During test runs this errors out and does not print an error because there is no catch on the apploader.getAppFilesString(app) promise.
There currently seems to be something wrong with the test reset since running single tests (not all tests for a single app) works while running more than one fails with
Uncaught SyntaxError: Got [ERASED] expected EOF. I'm pretty sure that is a different issue and only hidden by this one.