Skip to content

Fix reference to undefined device object in appinfo#90

Merged
gfwilliams merged 1 commit into
espruino:masterfrom
halemmerich:fixUndefinedReference
Jun 8, 2026
Merged

Fix reference to undefined device object in appinfo#90
gfwilliams merged 1 commit into
espruino:masterfrom
halemmerich:fixUndefinedReference

Conversation

@halemmerich

@halemmerich halemmerich commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

This currently causes the CI app tests for the BangleApps repo to essentially just always return fine since no tests are actually run. During test runs this errors out and does not print an error because there is no catch on the apploader.getAppFilesString(app) promise.

There currently seems to be something wrong with the test reset since running single tests (not all tests for a single app) works while running more than one fails with Uncaught SyntaxError: Got [ERASED] expected EOF. I'm pretty sure that is a different issue and only hidden by this one.

@gfwilliams

Copy link
Copy Markdown
Member

Thanks for spotting this!

Yes, that SyntaxError: Got [ERASED] expected EOF sounds different. It usually happens when the device has booted up and then all the code in flash is erased - I guess reset() still calls .boot0 which could be leaving some code in there. reset(1) would also delete boot code, so maybe just changing that in the test runner would do it.

@gfwilliams gfwilliams merged commit 99110f1 into espruino:master Jun 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants