fix(esp_codec): calloc argument warning#65
Open
bryghtlabs-richard wants to merge 2 commits into
Open
Conversation
Fix order of calloc arguments to address the following warning: esp_codec/audio_sonic.c: warning: 'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Wcalloc-transposed-args] sonic->inbuf = (short *)calloc(sizeof(short), BUF_SIZE);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix order of calloc arguments to address the following GCC warning:
esp_codec/audio_sonic.c:
warning: 'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Wcalloc-transposed-args]
sonic->inbuf = (short *)calloc(sizeof(short), BUF_SIZE);
The code above is attempting to allocate a buffer of type short, with BUF_SIZE elements, but is actually asking calloc to allocate space for 2x adjacent BUF_SIZE buffers. Swap the order to address this. On ESP32, the allocated memory would be the same size anyhow.
Testing
Testing in progress. Should be a side-effect-free warning fix, but still working on getting initial examples to compile.
Checklist
Before submitting a Pull Request, please ensure the following: