Show "Via the network" instead of "Wirelessly" in logs dialog for Ethernet devices#918
Open
tieskuh wants to merge 1 commit into
Open
Show "Via the network" instead of "Wirelessly" in logs dialog for Ethernet devices#918tieskuh wants to merge 1 commit into
tieskuh wants to merge 1 commit into
Conversation
tieskuh
force-pushed
the
logs-dialog-ethernet-label
branch
from
bdfab6c to
2696c3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
The "How to get the logs for your device?" dialog always labels the OTA option "Wirelessly". For devices that are connected via Ethernet this is misleading — the connection is wired, there is nothing wireless about it.
The install dialog already handles this case:
install-choose-dialog.tsshows "Via the network" when the configuration uses theethernetcomponent. This PR applies the exact same logic to the logs target dialog:firstUpdated()and set_ethernetbased onloaded_integrations.includes("ethernet")WiFi-based devices keep the existing "Wirelessly" label, identical to the install dialog behaviour.