Verify YAML editor saves before opening install dialog#909
Open
RubenKelevra wants to merge 2 commits into
Open
Verify YAML editor saves before opening install dialog#909RubenKelevra wants to merge 2 commits into
RubenKelevra wants to merge 2 commits into
Conversation
RubenKelevra
force-pushed
the
editor-failure-to-save-check
branch
from
d98077f to
5ab881d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that sometimes I get a "saved" popup, when I try to select 'install' in the ESPHome Web UI, while the browser is actually in some kind of hung up state. It will then show the selection of install options, but when I select the option device plugged into ESPHome server, I get just a "waiting for response circle animation". When I hit F5 after 2-3 minutes, I get the page reloaded, but my changes are gone - and this despite the UI showing, that the changes are successfully stored.
To counteract this I implemented a cache no store flag on the server and the client, compare the read back and also avoid showing the install popup when storing wasn't successful.