Repository navigation
Write UI strings in sentence case - #17
Merged
Merged
Conversation
Buttons, titles and labels in en, fr, es read in Title Case
("New Ticket", "Pièces Jointes"). Only the first word of each
string is capitalised now, plus acronyms such as SLA. German keeps
its capitalised nouns; only "Nicht Hilfreich" changes. Keys are
unchanged. A test holds en, fr, fr_CA and es to sentence case.
The tab bar hard-coded "Tickets", "Knowledge Base" and "Settings" in English Title Case. It now reads them from the host's locale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
User-facing strings in
en,frandeswere in Title Case ("New Ticket", "Create Ticket", "Browse Files", "Pièces Jointes", "Iniciar Sesión"). They are now sentence case: only the first word of each string (or sentence) is capitalised, plus acronyms such as SLA.Votre courriel); it inherits the fixedfrstrings.Nicht Hilfreichchanges toNicht hilfreich.Tickets/Knowledge Base/Settingsin English; it now uses the existingtickets/knowledge_base/settingskeys, so it follows the host's locale.Convention
escalated-developer-context/CONVENTIONS.mdhas no rule on UI copy casing (it covers code naming only). Sentence case is applied because host brand guides (Hauloy) require it and it is the platform norm on Material / iOS. Worth adding a line to CONVENTIONS.md.Tests
en,fr,fr_CAandestables must be sentence case (per sentence; all-caps acronyms allowed), plus spot checks onnew_ticket,attachments(fr),create_ticket(fr_CA) andnot_helpful(de).flutter analyze: no issues.flutter test: 26 passed.