db/recsplit: enable sharded FuseFilter by default#21797
Open
AskAlexSharov wants to merge 1 commit into
Open
Conversation
## Summary Re-enable the sharded FuseFilter existence-filter format by setting `ExistenceFilterVersion` back from `1` to `2` in `db/recsplit/recsplit.go`. This is the switch that #21164 turned off after #20644 introduced the format. New index files (`.kvi`/`.efi`) will again embed the sharded BinaryFuse filter (256 shards by `keyHash>>56`), which cuts existence-filter build-time RAM ~256× (the motivation was bloatnet 3B-key `.efi` builds). ## Why it's safe - **Read path is version-aware.** `db/recsplit/index.go` reads the embedded `dataStructureVersion` per file and dispatches to v0/v1/v2 readers, so existing v1 files stay readable and new v2 files are read by the matching `case 2` path. - **Accessor/existence files are built locally, not seeded.** `SeedableV3Extensions()` publishes only `.kv/.v/.ef/.ap`; `.kvi/.efi/.kvei` are rebuilt locally via `BuildMissedAccessors`, so this does not affect the shared snapshot set. ## Test plan - [ ] CI green Co-authored-by: JkLondon <me@ilyamikheev.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #21793 to performance branch.