[wip] [3.6] commitment: skip GetLatest for keys creation#21790
Open
AskAlexSharov wants to merge 3 commits into
Open
[wip] [3.6] commitment: skip GetLatest for keys creation#21790AskAlexSharov wants to merge 3 commits into
GetLatest for keys creation#21790AskAlexSharov wants to merge 3 commits into
Conversation
When branchBefore[row] is false the branch did not exist in DB at unfold
time, so the WarmupCache and ctx.Branch() lookups in CollectUpdate /
CollectDeferredUpdate return empty unconditionally. Pass isNew=true from
foldBranch to skip both calls and supply []byte{} as the known-empty prev
sentinel, which also causes DomainPut to skip its internal GetLatest().
AskAlexSharov
changed the title
AskAlexSharov
changed the title
AskAlexSharov
changed the title
AskAlexSharov
changed the title
AskAlexSharov
changed the title
GetLatest for keys creation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #21789 to main
PutBranch does call GetLatest inside - if we don't pass
prevVal- this PR passing it for "new keys" (which not exists in commitment domain) - we have this metadatata in trie already.