db/state: replace ExistenceFilterOnAppMemory with ExistenceFilterMode enum#21788
Open
AskAlexSharov wants to merge 1 commit into
Open
db/state: replace ExistenceFilterOnAppMemory with ExistenceFilterMode enum#21788AskAlexSharov wants to merge 1 commit into
AskAlexSharov wants to merge 1 commit into
Conversation
… enum Introduce ExistenceFilterMode (InMem=0, WillNeed=1, Normal=2, Random=3) on DomainCfg instead of a bool. Zero value (InMem) is the common case, so no schema lines are needed for the default. All four debug env vars are now per-domain name lists: DOMAIN_EXISTENCE_MEM=accounts,storage — override to InMem DOMAIN_EXISTENCE_WILLNEED=accounts — override to WillNeed DOMAIN_EXISTENCE_NORMAL=accounts — override to Normal DOMAIN_EXISTENCE_RANDOM=accounts — override to Random MadvRandom plumbed through fusefilter.Reader, fusefilter.ReaderSharded, existence.Filter, and recsplit.Index.
db8a429 to
3e47d4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #21776 to main.