cl/sentinel: pass ctx through StartSentinelService → stickToPeers#21786
Open
AskAlexSharov wants to merge 1 commit into
Open
cl/sentinel: pass ctx through StartSentinelService → stickToPeers#21786AskAlexSharov wants to merge 1 commit into
AskAlexSharov wants to merge 1 commit into
Conversation
`StartSentinelService` now accepts a `context.Context` instead of creating its own `context.Background()`. The ctx flows into `createSentinel` → `sentinel.New` (stored as `s.ctx`) and into `stickToPeers`, which replaces `time.Sleep` with a `select` on `s.ctx.Done()` so the goroutine exits cleanly on shutdown.
Giulio2002
approved these changes
Jun 13, 2026
Giulio2002
left a comment
Giulio2002
left a comment
Contributor
There was a problem hiding this comment.
LGTM — threads the existing context into Sentinel startup and replaces an uninterruptible sleep with ctx-aware waiting.
Giulio2002
approved these changes
Jun 13, 2026
Giulio2002
left a comment
Giulio2002
left a comment
Contributor
There was a problem hiding this comment.
LGTM — threads the existing context into Sentinel startup and replaces an uninterruptible sleep with ctx-aware waiting.
Giulio2002
approved these changes
Jun 13, 2026
Giulio2002
left a comment
Giulio2002
left a comment
Contributor
There was a problem hiding this comment.
LGTM — small context-plumbing cleanup so the static-peer reconnect loop can stop cleanly on shutdown.
Giulio2002
approved these changes
Jun 13, 2026
Giulio2002
left a comment
Giulio2002
left a comment
Contributor
There was a problem hiding this comment.
LGTM — small context-plumbing cleanup so the static-peer reconnect loop can stop cleanly on shutdown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StartSentinelServicewas creating its owncontext.Background(), so the sentinel goroutines had no way to receive shutdown signals.This PR threads the caller's
ctxall the way down:StartSentinelServicegains actx context.Contextfirst parametercreateSentinelforwards it tosentinel.New(which stores it ass.ctx)stickToPeersreplacestime.Sleep(3 * time.Minute)with aselectons.ctx.Done(), so the reconnect goroutine exits cleanly when the context is cancelled