Repository navigation
fix(runner): load Claude sandbox settings from a file - #231
AmeinEskinder wants to merge 2 commits into
Conversation
Merge Protections🟠 1 of 2 protections blocking · waiting on 🤖 CI
🟠 Queue ready pull requestsWaiting for
Waiting checks:
|
|
[Medium impact] The code changes appear safe to merge, subject to the repository’s required exact-head live gate. SummaryMoves Claude writer sandbox settings from inline JSON to a private
No actionable defects were found. This review used source inspection; tests and live launches were not run. Reviews (1) · Last reviewed commit: "fix(runner): load Claude sandbox setting..." · Reviewed by Greptile |
|
Thank you for this, and for the clear diagnosis. Tracing the failure to We aren't merging it now. Claude Code's sandboxing docs say the sandbox runs on macOS, Linux and WSL2, and that on native Windows Claude Code runs commands unsandboxed. The runner sets #230 stays open until Claude Code supports the sandbox on native Windows. Your settings-file design is the one we'd port then, with you as co-author. Could you post the Claude Code version and the startup message that mentioned the Windows sandbox feature gate? If Claude Code gives you a way to turn that sandbox on, tell us on #230 and we'll pick this up again. |
Why
Claude writer lanes fail before launch on Windows because Bun refuses inline JSON arguments to
claude.cmd. Pass the sandbox settings as a file path while preserving every sandbox control and the shared Git directory write denial. Fixes #230.What changed
--settingsand retain the current permission and tool controls.Scope
Tradeoffs
Provider sidecars are declared per adapter, so Claude readers also reserve an empty settings file. Readers continue to request plan mode without passing
--settings.Blast Radius
Provider config builders can receive the discovered shared Git directory. Existing providers keep their current config contents, and exclusive file creation still fails closed.
Verification
args[9]error. The regression and Claude adapter tests pass after the fix, 22 tests total.claude:runner,codex:runner, and bothproject-skillcases.