[pull] main from hookdeck:main#149
Merged
Merged
Conversation
…ailing checks (#950) Trigger: PR #945 hit a heuristic FAIL on scenario 02 because the TS SDK flattened `outpost.publish.event(...)` to `outpost.publish(...)` in v1.3.0 (commit d875c66), but the eval check + scenario criterion + prompt were never updated. Prior runs masked it: the agent often echoed the literal "publish.event" from the prompt in comments, accidentally satisfying the string-presence check. This run stuck to the SDK README wording and the check exit-1'd with no clue in the GH Actions log — only in the artifact. Impact: PR #945 (docs only) was blocked by an unrelated stale check. After this fix the heuristic matches the current SDK shape, and any future heuristic/LLM failure prints the failing check id and detail directly in the main CI log. Changes: - scoreScenario02 regex now matches `.publish(` and keeps `publish.event` as a fallback for older transcripts. - run-agent-eval logs each failing heuristic check + LLM criterion on pass=false (was: silent exit 1). - Scenario 02 success criterion lists `outpost.publish` not `publish.event`. - Prompt's TS counter-example uses `outpost.publish({ ... })`. - Trajectory SDK hint pattern renamed `ts_publish` with `/\.publish\s*\(/`. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )