fix(openapi): allow cancel deployment with login session#6789
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5ca32e059
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| i18n.SetGoroutineBindLang(localeName) | ||
| // clear all global context | ||
| defer goroutine_context.ClearContext() | ||
| defer redactSensitiveRequestHeaders(r.Header) |
There was a problem hiding this comment.
Redact sensitive headers before request dumps
When HTTP_DUMP or the __dump__ query flag is enabled, this defer runs only after the inner handler returns, while the dump interceptor is configured with order 0 and calls httputil.DumpRequest before invoking the next handler; this filter is order 11 in cmd/erda-server/bootstrap.yaml. As a result Authorization, Cookie, and CSRF values are still printed by the dump path despite this redaction, so the redaction needs to happen in the dump interceptor or before it runs.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6789 +/- ##
=======================================
Coverage 15.84% 15.85%
=======================================
Files 3998 3998
Lines 328165 328175 +10
=======================================
+ Hits 51989 52023 +34
+ Misses 270277 270252 -25
- Partials 5899 5900 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
What this PR does / why we need it:
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @your-reviewer
ChangeLog
Need cherry-pick to release versions?