Skip to content

fix: support python and build with golang 1.22#83

Open
CeerDecy wants to merge 3 commits into
erda-project:masterfrom
CeerDecy:fix/sonar-support-python
Open

fix: support python and build with golang 1.22#83
CeerDecy wants to merge 3 commits into
erda-project:masterfrom
CeerDecy:fix/sonar-support-python

Conversation

@CeerDecy

Copy link
Copy Markdown
Member

Description

fix: support python and build with golang 1.22

Checklist

  • I made sure to check the compatibility of the erda version statemented in the action's spec.yml.
  • My change is adequately tested.

@@ -1,4 +1,4 @@
FROM --platform=$TARGETPLATFORM registry.erda.cloud/erda/terminus-golang:1.16.7 AS builder
FROM --platform=$TARGETPLATFORM registry.erda.cloud/erda-x/golang:1.22 AS builder

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--platform=$TARGETPLATFORM can remove.

RUN GOPROXY=https://goproxy.io,direct GOOS=linux GOARCH=$ARCH go build -o /assets/run actions/sonar/1.0/internal/*.go

FROM --platform=$TARGETPLATFORM registry.erda.cloud/erda/terminus-centos:base AS action
FROM --platform=$TARGETPLATFORM m.daocloud.io/docker.io/debian:bookworm AS action

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use erda-x base image, plz.

FROM --platform=$TARGETPLATFORM m.daocloud.io/docker.io/debian:bookworm AS action

RUN yum install -y wget unzip
RUN apt-get update && apt install -y wget unzip curl ca-certificates

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already contains in erda-x base image.

@iutx iutx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants