Fix imsave#34
Merged
Merged
Conversation
added 2 commits
August 12, 2025 10:38
ercius
added a commit
that referenced
this pull request
Aug 12, 2025
* Klever update (#26) * these are all Klever's final changes * add venv and other directoires to gitignore * Update pyproject.toml bump to v1.1 before new release * Klever update 2 (#27) * these are all Klever's final changes * add venv and other directoires to gitignore * Adjusted the code slightly to fix scale bar issues. * Beam center update (#28) * Fix missing ) and change comments * Change the beam centering to row/col rather than x/y. This keeps the convention the same within DuSC. For exmaple, the corner of a ROI box is printed in the status bar as row/col. * change the beam center in the other lines * synchronize metadata and remove hard coding * Final clean up --------- Co-authored-by: Peter Ercius ncem-gauss jupyter <percius.lbl.gov> * remove hard coded frame dimensions (#29) Co-authored-by: Peter Ercius ncem-gauss jupyter <percius.lbl.gov> * bump version for release * ensure non-ragged array is uint32 dtype (#30) Co-authored-by: Peter Ercius ncem-gauss jupyter <percius.lbl.gov> * Bump version to fix jit typing issue. * Update README.md Update code lines. Link to the tutorial Link to example data sets in Zenodo * user older titfffile version (v2025.1.10) to avoid deprecation issue. (#32) * user older titfffile version (v2025.1.10) to avoid deprectaion issue. * bump version --------- Co-authored-by: Peter Ercius ncem-gauss jupyter <percius.lbl.gov> * remove old code * Fix imsave (#34) * Use tifffile imwrite instead of imsave. Check for file extension in real space file write. * remove limit on tifffile version and bump dusc version --------- Co-authored-by: Peter Ercius ncem-gauss jupyter <percius.lbl.gov> --------- Co-authored-by: Klever2003 <157851065+Klever2003@users.noreply.github.com> Co-authored-by: Peter Ercius ncem-gauss jupyter <percius.lbl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the limit on the
tifffileversion identified in #31 and usestiffifle.imwriteinstead. It also fixes a small bug where the real space image suffix was not checked for .tif.