fix(sandbox): require local runtime opt-in#3092
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
he-yufeng
force-pushed
the
fix/sandbox-local-runtime-opt-in
branch
from
ce34bf9 to
79663d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3082.
The sandbox runtime factory used to fall back to
LocalRuntimewhen no container runtime was available. That path runs submitted code on the host, so this changes the default behavior to fail closed unless host-local execution is explicitly enabled.Changes
SANDBOX_RUNTIMEunset by default so runtime selection can auto-detect container runtimesSANDBOX_ALLOW_LOCAL_RUNTIME=truebeforeLocalRuntimecan be selectedTo verify
PYTHONPATH=packages/dbgpt-sandbox/src python -m pytest packages/dbgpt-sandbox/tests/test_runtime_factory.py -qgit diff --checkPYTHONPATH=packages/dbgpt-sandbox/src python -m py_compile packages/dbgpt-sandbox/src/dbgpt_sandbox/sandbox/config.py packages/dbgpt-sandbox/src/dbgpt_sandbox/sandbox/execution_layer/runtime_factory.py packages/dbgpt-sandbox/tests/test_runtime_factory.py