fix: prevent path traversal in plugin install via branch_name sanitiz…#3084
Open
AAtomical wants to merge 1 commit into
Open
fix: prevent path traversal in plugin install via branch_name sanitiz…#3084AAtomical wants to merge 1 commit into
AAtomical wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
branch_nameparameter inupdate_from_git()to strip..and.path components before use in file path constructiondownload_param.branch_nameinPOST /api/v1/agent/hub/updateProblem
packages/dbgpt-core/src/dbgpt/agent/resource/tool/autogpt/plugins_util.py:175constructs a file path using unsanitized user input:branch_nameoriginates from thedownload_paramJSON field in the API request body. A malicious value likemain/../../etc/cron.d/pwnallows writing attacker-controlled content outside the intended plugins directory.Fix
Two layers of defense:
Input sanitization (
_sanitize_branch_name): strips..,., and backslash-based traversal from branch name before it enters any path logic.Output containment check: after constructing the final path, resolves it to an absolute path and verifies it remains under the plugins base directory. Raises
ValueErrorif the resolved path escapes.Changed files
packages/dbgpt-core/src/dbgpt/agent/resource/tool/autogpt/plugins_util.pyTest plan
main,dev,feature/foo)branch_namecontaining../raisesValueErrorbranch_namecontaining absolute path components raisesValueErrorThe issue linked is #3083