Migrate to Lyrical#4
Merged
Merged
Conversation
This fixes an issue with visualization of the UTM path in Foxglove Studio which requires that the path frame_id match all the pose frame_ids.
* update msg for Kilted * [opennav_coverage_bt] migrate BT xml files * migrate coverage_navigator * rm error_msg from ComputeCoveragePath * use newer rostooling docker images, run test for Kilted * run linter on Kilted * use base image
due to wrong includes and to methods that moved from nav2_util to nav2 namespace
to avoid clashes between navigators
Roboterbastler
requested changes
Aug 21, 2025
Roboterbastler
left a comment
Roboterbastler
left a comment
There was a problem hiding this comment.
Just two very minor comments. Otherwise if I'm not mistaken I have already tested this as the submodule is currently set to this branch.
Roboterbastler
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream PR:
open-navigation#95
Ideally we don't need this, but the upstream PR is stuck on CI