Differ explicit epoch from null in timestamp conversion.#236
Merged
Conversation
Contributor
|
Thanks @bonitao |
Contributor
|
Reverted. Should be revisited when #177 is worked on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got a null point exception when I was mapping a pojo with a field with an explicit Instant.EPOCH value to a protocol buffer where the field of same name was a Timestamp.
It seems that the decision of mapping epoch to null was deliberate, but it did not feel correct to me. See the added test cases, and let me know if you would prefer a different fix.