NXT-13026 Convert SpotlightRootDecorator to functional component#3419
Open
dan-ichim-lgp wants to merge 3 commits into
Open
NXT-13026 Convert SpotlightRootDecorator to functional component#3419dan-ichim-lgp wants to merge 3 commits into
dan-ichim-lgp wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3419 +/- ##
===========================================
+ Coverage 84.81% 85.64% +0.82%
===========================================
Files 156 156
Lines 7540 7542 +2
Branches 2000 2001 +1
===========================================
+ Hits 6395 6459 +64
+ Misses 905 863 -42
+ Partials 240 220 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Dependencies were not being installed before running screenshot tests on the remote worker.
Resolution
Added the missing npm install step for the theme repository in the remote screenshot test script.
Additional Considerations
No side effects. The non-remote screenshot test script was already handling this correctly.
Links
NXT-14013
Comments
Enact-DCO-1.0-Signed-off-by: Dan Ichim (dan.ichim@lgepartner.com)