Refactor library interface#16
Merged
Merged
Conversation
Jonty
reviewed
May 16, 2026
Jonty
reviewed
May 16, 2026
Member
|
Spotted two issues in the tests that need resolving, but other than that LGTM. Some of this is way better! |
russss
force-pushed
the
interface-refactor
branch
from
2538c48 to
b933a7e
Compare
Member
Author
|
Both of those should be sorted now. Also added a few more tests and removed the unittest dependency. |
This draws a clean boundary between the external interface, which operates in datetimes, and the solver, which operates in slots. It improves type checking and makes writing tests a lot more straightforward. Fixes #7
russss
force-pushed
the
interface-refactor
branch
from
b933a7e to
07eb723
Compare
russss
force-pushed
the
interface-refactor
branch
from
2523558 to
2580135
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draws a clean boundary between the external interface, which operates in datetimes, and the solver, which operates in slots. It improves type checking and makes writing tests a lot more straightforward.
Fixes #7