Missing await on async sleep calls#331
Open
Jonty wants to merge 1 commit into
Open
Conversation
ChrisDick
requested changes
Jun 11, 2026
| if TwentyTwentyFour.hexpansion_states[hexindex] is None: | ||
| TwentyTwentyFour.hexpansion_states[hexindex] = now | ||
| eventbus.emit_async(HexpansionInsertionEvent(port=hexindex)) | ||
| await eventbus.emit_async(HexpansionInsertionEvent(port=hexindex)) |
Contributor
There was a problem hiding this comment.
this await breaks the buttons, should be non async emit instead. this is one of the callbacks used by the c code, so just goes on the mp scheduler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted an async sleep missing an await (so it wouldn't do anything), grepping found a couple more missing awaits.