Skip to content

Add call to deinit hexpansion apps #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hairymnstr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add call to deinit hexpansion apps #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions modules/system/hexpansion/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,11 @@ def _launch_hexpansion_app(self, port):

self._cleanup_import_path(old_cwd, old_sys_path)

def _stop_hexpansion_app(self, app, port):
print(f"Trying to stop app: {app}")
eventbus.emit(RequestStopAppEvent(app))
def _stop_hexpansion_app(self, port):
print(f"Trying to stop app: {self.hexpansion_apps[port]}")
eventbus.emit(RequestStopAppEvent(self.hexpansion_apps[port]))
if hasattr(self.hexpansion_apps[port], "deinit"):
self.hexpansion_apps[port].deinit()
del self.hexpansion_apps[port]

# Clean up imported hexpansion modules
Expand Down Expand Up @@ -294,7 +296,7 @@ async def handle_hexpansion_removal(self, event):
header = None

if event.port in self.hexpansion_apps:
self._stop_hexpansion_app(self.hexpansion_apps[event.port], event.port)
self._stop_hexpansion_app(event.port)

if event.port in self.hexpansion_headers:
header = self.hexpansion_headers[event.port]
Expand Down
Loading