Make App Store codeinstall see keyboard buttons#327
Open
benclifford wants to merge 1 commit into
Open
Conversation
Before this PR, the code input dialog only did directional frontboard A-F buttons, even though codes are often represented as numbers. It did not respond to button pushes for actual number buttons on tildagons with those additional button types (in my case, my usb serial keyboard driver, but I guess also any other external keyboard? I'm not sure?) After this PR, you can use the frontboard A-F buttons as before or press numerical keys if you have them.
benclifford
force-pushed
the
codeinstall-keyboard
branch
from
80fce20 to
338567a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, the code input dialog only did directional frontboard A-F buttons, even though codes are often represented as numbers.
It did not respond to button pushes for actual number buttons on tildagons with those additional button types
(in my case, my usb serial keyboard driver, but I guess also any other external keyboard? I'm not sure? it's also "broken" behaviour inside the web emulator which has a keyboard driver)
After this PR, you can use the frontboard A-F buttons as before or press numerical keys if you have them.