Allow hexpansions to add themselves to launcher#321
Open
walkerdanny wants to merge 4 commits into
Open
Conversation
…emove functions since duplicated in main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As per #317 and #184 this is a working (as far as my testing has revealed) way for hexpansion EEPROM apps to add themselves to the launcher.
It adds four new event types to add a hexpansion to launcher, remove a hexpansion from launcher, start a hexpansion app and stop a hexpansion app. Not crazy about the names of these so please suggest better ones if you have ideas, naming things is hard.
This is done on a port number basis, so multiple hexpansions of the same type should each be able to have their own instance of the app. That felt like the right approach.
The hexpansion glyph allocated in #316 is prepended to app names so they appear in the launcher with a hexpansion next to them (eventually)
I get the occasional glitch with this that sorts itself out after a while, but I think this happens when a hexpansion isn't inserted properly or gets inserted and removed quickly, so it's probably not unique behaviour to this branch.
A minimum working hexpansion app for testing is: