Fix previously installed apps not launching when using mpremote mount#300
Open
b0xcat wants to merge 2 commits into
Open
Fix previously installed apps not launching when using mpremote mount#300b0xcat wants to merge 2 commits into
b0xcat wants to merge 2 commits into
Conversation
Member
|
@b0xcat Won't lots of things be broken if What are we trying to do with mount? It looks like it's designed to take over the entire FS, so wouldn't we want it to reinitialise the menu to only have the mounted apps? |
Contributor
Author
|
Hmm good point, maybe that's a better way of doing it. I just kind of quickly did this because I ran into this specific issue playing around. Will take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a small issue launching apps that were previously already installed when using
mpremote mount.mpremote mountunder the hood doesos.chdir('/remote')which causes apps previously installed to/appsto fail when we try to import them. This provides a fallback that temporarily switches back to the old cwd, imports the app, and restores the /remote cwd after.