fix(bootstrap): PROXBOX_SKIP_NETBOX_BOOTSTRAP for Docker CI#26
Merged
Conversation
…tests In-container checks import proxbox_api.main without a NetBox row; avoid ERROR stack traces by skipping default NetBox client when env is set. Still create SQLite schema and load endpoint rows for CORS. Docker workflows export the var in the shared test script.
…cile E2E idempotent device test could fail when POST errored (e.g. duplicate) but GET filters did not return the existing site. Always re-fetch and run the limited list scan before re-raising, not only for specific error wording.
- Add image_http marker and test_image_http_smoke (httpx) for /, /docs, openapi - Replace e2e-tests with e2e-sequential: one NetBox pass, then serial Docker smoke - needs docker-images when it runs so :latest matches the same push - Add httpx to e2e extra; refresh uv.lock
Scanning only the first 200 list rows missed existing sites on busy demo NetBox. Paginate up to 10k offset. CI pull_request types: opened, synchronize, reopened, ready_for_review so pushes to PRs like #26 reliably re-run workflows.
Remove ci-basic.yml (ruff/compile/import already run in CI test job). Rename e2e-sequential → e2e-tests so required checks match; keep three serial phases.
…production Docker image
…2E testing - Add playwright as runtime extra in pyproject.toml - Install playwright in Dockerfile via uv sync --extra playwright - Trigger docker-hub-publish on PRs to build fresh images - Add PR SHA tags to Docker images for E2E testing - Revert E2E jobs to use docker-images job (needs test, docker-images)
Branch protection requires a status named e2e-tests; parallel jobs only reported e2e-demo, e2e-http, and e2e-https, leaving merges blocked. Add a final job that succeeds only when all three complete successfully.
Required checks on main are now test, e2e-demo, e2e-http, e2e-https.
emersonfelipesp
added a commit
that referenced
this pull request
Apr 13, 2026
Scanning only the first 200 list rows missed existing sites on busy demo NetBox. Paginate up to 10k offset. CI pull_request types: opened, synchronize, reopened, ready_for_review so pushes to PRs like #26 reliably re-run workflows.
emersonfelipesp
added a commit
that referenced
this pull request
Apr 13, 2026
fix(bootstrap): PROXBOX_SKIP_NETBOX_BOOTSTRAP for Docker CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid NetBox bootstrap errors when GitHub Actions runs
import proxbox_api.maininside the image without a configured endpoint. SetPROXBOX_SKIP_NETBOX_BOOTSTRAP=1in the shared Docker test script.