Repository navigation
fix: send asknews-cli/<version> as User-Agent - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔴 Review tier: HIGH — human review required
fix:onmainfeeds the next release-please Release PR, which publishes to npmWhat
Every request the CLI sends to the API gateway now carries
User-Agent: asknews-cli/<package version>, next to the SDKs' ownasknews-sdk-<lang>agents. The gateway uses it to attribute usage to the CLI channel; until now CLI traffic was indistinguishable from raw API calls.src/lib/version.ts: single source of the package version and the user agent string (cli.tsreads the version from it too).src/lib/http.ts: header set in both request builders (raw requests and schema operations, buffered and streamed).Verified
pnpm lintandpnpm typecheckpass.pnpm test: the 4 new tests intest/user-agent.test.tspass (raw, operation and streamed requests all send the header). One failure intest/output.test.ts(web search table rendering) is pre-existing onmainand unrelated.Umbrella:
em-hub/features/usage-client-id/