Repository navigation
Deprecation enabled / URL updates for 7.5.0 - #21745
Conversation
📊 Size reportTarball size — dist/dev 0.02%↑
dist/prod 0.02%↑
smoke-tests/v2-app-template/dist 0.09%↑
smoke-tests/v2-app-hello-world-template/dist 0.2%↑
🤖 This report was automatically generated by wyvox/pkg-size |
|
The only ones implemented, but aren't ready to bump their enabled are these ones: ember-learn/deprecation-app#1404 (PR needs review, and perhaps changes) |
| id: 'deprecate-evented', | ||
| for: 'ember-source', | ||
| since: { available: '7.3.0' }, | ||
| since: { available: '7.3.0', enabled: '7.5.0' }, |
There was a problem hiding this comment.
The target action support one is fine but these others need the RFCs to go to 'Ready for release' aka Advance to released stage
There was a problem hiding this comment.
you mean we can't release a deprecation that is available and enabled in the same version?
There was a problem hiding this comment.
or we just can't merge this PR until we advance all the corresponding RFC PRs on monday?
There was a problem hiding this comment.
the later ... the RFCs should be in the 'ready for release' stage, aka waiting to release
There was a problem hiding this comment.
ye!
- Advance RFC #1112
"Deprecating Ember Proxies"to Stage Released rfcs#1260 - Advance RFC #0334
"Deprecate Ember Utils & dependent Computed Properties"to Stage Released rfcs#1259 - Advance RFC #1114
"Deprecating Ember Array"to Stage Released rfcs#1258 - Advance RFC #1111
"Deprecating Ember.Evented and @ember/object/events"to Stage Released rfcs#1257 - Advance RFC #1116
"Deprecating Mixin Support"to Stage Released rfcs#1256 - Advance RFC #1041
"Deprecate TargetActionSupport"to Stage Released rfcs#1222
There was a problem hiding this comment.
Did we skip the FCP to go to Ready for Release?
There was a problem hiding this comment.
We did, yea -- it didn't occur to anyone on the call that it would be needed
I do see the "Ready for Release" section says that FCP is required to move in to "Ready for Release" :(
https://github.com/emberjs/rfcs#ready-for-release
:(
ember.js 7.5 enabled the deprecation of `A` from `@ember/array` (emberjs/ember.js#21745). In the ember-canary scenario, the "Updates are published when they happen" test called `emberA()`. ember-debug then sent `deprecation:count` after `promisesUpdated`, so the test read `message.promises` from the wrong message and threw. The `emberA()` wrappers only fed native `find`, and no test visits the route whose model used `A()`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
enable all implemented deprecations