Skip to content

Add PrivateKeyFileWithPassphrase from #11#20

Open
JamesGDiaz wants to merge 7 commits into
elliotchance:masterfrom
JamesGDiaz:master
Open

Add PrivateKeyFileWithPassphrase from #11#20
JamesGDiaz wants to merge 7 commits into
elliotchance:masterfrom
JamesGDiaz:master

Conversation

@JamesGDiaz

@JamesGDiaz JamesGDiaz commented Jan 11, 2024

Copy link
Copy Markdown

Create a pull request for the code by @fagnercarvalho on issue #11 , he never created his PR so I did it for him


This change is Reviewable

Comment thread endpoint_test.go
"testing"

"github.com/elliotchance/sshtunnel"
"github.com/jamesgdiaz/sshtunnel"

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you fork a package you should clone it to the path of the original package so that you don't have to change these.

Comment thread private_key_file.go
return ssh.PublicKeys(key)
}

// All credits go to the author fagnercarvalho

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants