Fix regressions with Del and NumPad arrow keys in TTY and WX backends related to the new Kitty keyboard protocol#3410
Open
unxed wants to merge 2 commits into
Open
Fix regressions with Del and NumPad arrow keys in TTY and WX backends related to the new Kitty keyboard protocol#3410unxed wants to merge 2 commits into
unxed wants to merge 2 commits into
Conversation
… related to the new Kitty keyboard protocol 1. Update `IsEnhancedKey` in `TTYBackend.cpp` to include `VK_INSERT` and `VK_DELETE` so they receive the `ENHANCED_KEY` flag, fixing TTY Del translation. 2. Modify `VT_TranslateKeyToKitty` to avoid appending `CAPSLOCK_ON` and `NUMLOCK_ON` modifiers to sequences unless alternate keys or full reporting is requested (`flags & (4 | 8)`). This prevents `nolegacy` from being spuriously activated when NumLock is on, allowing proper fallback to legacy sequences. 3. `VT_TranslateKeyToKitty` to fall back to legacy sequence behavior for NumPad navigation keys unless full reporting mode (`flags & 8`) is requested, ensuring compatibility with applications that do not support the full Kitty protocol. Fixes elfmz#3409
unxed
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsEnhancedKeyinTTYBackend.cppto includeVK_INSERTandVK_DELETEso they receive theENHANCED_KEYflag, fixing TTY Del translation.VT_TranslateKeyToKittyto avoid appendingCAPSLOCK_ONandNUMLOCK_ONmodifiers to sequences unless alternate keys or full reporting is requested (flags & (4 | 8)). This preventsnolegacyfrom being spuriously activated when NumLock is on, allowing proper fallback to legacy sequences.VT_TranslateKeyToKittyto fall back to legacy sequence behavior for NumPad navigation keys unless full reporting mode (flags & 8) is requested, ensuring compatibility with applications that do not support the full Kitty protocol.Fixes #3409