feat(netrocks): add SSH private key passphrase prompt#3399
Open
michaellukashov wants to merge 2 commits into
Open
feat(netrocks): add SSH private key passphrase prompt#3399michaellukashov wants to merge 2 commits into
michaellukashov wants to merge 2 commits into
Conversation
- Add ProtocolKeyPassphraseNeededError exception type - Add IPC_PI_KEY_PASSPHRASE_NEEDED IPC message - Add InteractivePassphraseDialog with passphrase input - Wire passphrase prompt in HostRemote::ReInitialize() with retry logic (3 attempts) - Add language strings for English, Russian, and Belarusian - Pass passphrase exception through HostRemoteBroker
- Change button label from "Connect" to "OK" for consistency - Auto-select pre-filled passphrase text on retry for faster re-entry - Restructure layout with labels and fields on separate lines - Widen dialog to accommodate longer site names and passphrases - Fix separator rendering glitch by matching InteractiveLoginDialog proportions - Add inline InteractivePassphrase() handler in HostRemote::ReInitialize() (from prior implementation work, see .ai-factory/PLAN.md)
d05a6e5 to
98cf6ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH connections using encrypted private keys now prompt the user for a passphrase instead of failing immediately with a generic auth failure.
Changes
New exception type (Erroring.h, Erroring.cpp)
failures.
New IPC message (IPC.h)
Broker forwarding (HostRemoteBroker.cpp)
Passphrase dialog (InteractiveLogin.cpp, InteractiveLogin.h)
Retry loop (HostRemote.cpp::ReInitialize())
Localization (eng.lng, rus.lng, bel.lng)