Avoid redrawing background shadow on progress message updates#3299
Open
YuryChaikou-ServiceNow wants to merge 1 commit into
Open
Avoid redrawing background shadow on progress message updates#3299YuryChaikou-ServiceNow wants to merge 1 commit into
YuryChaikou-ServiceNow wants to merge 1 commit into
Conversation
YuryChaikou-ServiceNow
force-pushed
the
scratch/yc7
branch
2 times, most recently
from
8c6db93 to
b1ae463
Compare
Use MSG_KEEPBACKGROUND on subsequent progress Message() calls to prevent re-darkening the background on every update. This fixes visible flicker during: - Directory size calculation (F3) - Editor file loading (F4 on large files) - Editor file saving - Editor search with progress bar - Panel directory reading progress Track whether progress message has been shown with a bool flag in each loop, pass MSG_KEEPBACKGROUND on second and subsequent calls. PreRedraw callbacks are left unchanged (flags=0) since they run after full screen repaint where the popup must be fully redrawn including border and shadow.
YuryChaikou-ServiceNow
force-pushed
the
scratch/yc7
branch
from
b1ae463 to
ff30440
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use MSG_KEEPBACKGROUND on subsequent progress Message() calls to
prevent re-darkening the background on every update. This fixes
visible flicker during:
Track whether progress message has been shown with a bool flag
in each loop, pass MSG_KEEPBACKGROUND on second and subsequent
calls. PreRedraw callbacks are left unchanged (flags=0) since
they run after full screen repaint where the popup must be fully
redrawn including border and shadow.