Skip to content

Pad the formatted datetime#2666

Merged
lenemter merged 6 commits into
mainfrom
jeremypw/view-margin-end
Nov 7, 2025
Merged

Pad the formatted datetime#2666
lenemter merged 6 commits into
mainfrom
jeremypw/view-margin-end

Conversation

@jeremypw

@jeremypw jeremypw commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

Fixes #1538

BEFORE
Screenshot from 2025-11-03 11 02 47

AFTER (ISO format)
Screenshot from 2025-11-07 12 36 04
.

@jeremypw jeremypw added the Bitesize Simple, small diff label Nov 3, 2025
@jeremypw jeremypw added this to the 7.2.0 milestone Nov 3, 2025
@jeremypw
jeremypw marked this pull request as ready for review November 3, 2025 11:06
@jeremypw
jeremypw requested a review from a team November 3, 2025 11:07
@tintou

tintou commented Nov 3, 2025

Copy link
Copy Markdown
Member

That's not good because the headers also have a margin

@jeremypw

jeremypw commented Nov 3, 2025

Copy link
Copy Markdown
Contributor Author

That's not good because the headers also have a margin

Ah, that's a pity - it was the simplest solution 😞 I guess I will have to tweak the render instead.

@jeremypw
jeremypw marked this pull request as draft November 3, 2025 15:12
@jeremypw
jeremypw marked this pull request as ready for review November 3, 2025 15:33
@jeremypw

jeremypw commented Nov 3, 2025

Copy link
Copy Markdown
Contributor Author

I know that using spaces is not elegant but bearing in mind it will all have to be re-visited on porting to Gtk4 it does not seem worth spending a lot of time on it.

@jeremypw jeremypw changed the title Add end margin to view Pad the formatted datetime Nov 3, 2025

@lenemter lenemter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using ISO format the date is almost touching the scrollbar which looks weird.

image

@jeremypw

jeremypw commented Nov 7, 2025

Copy link
Copy Markdown
Contributor Author

Hmm, that's odd - all formats should have one space padding but I can increase it to 2 spaces if you think that looks better. Or maybe there is a fixed-width space char I can use.

@jeremypw

jeremypw commented Nov 7, 2025

Copy link
Copy Markdown
Contributor Author

Now using single unichar emspace for padding. With this there is no overlap even when hovered.

@jeremypw
jeremypw requested a review from lenemter November 7, 2025 12:38
Comment thread libcore/FileUtils.vala Outdated
@jeremypw
jeremypw requested a review from lenemter November 7, 2025 13:22
@lenemter
lenemter merged commit d397a94 into main Nov 7, 2025
4 checks passed
@lenemter
lenemter deleted the jeremypw/view-margin-end branch November 7, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bitesize Simple, small diff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Listview Vertical scrollbar is on top of modified date column information.

3 participants