Fix destination icon in file conflict dialog#2656
Merged
Merged
Conversation
This reverts commit 265c691.
jeremypw
marked this pull request as ready for review
October 31, 2025 13:06
lenemter
requested changes
Nov 7, 2025
|
|
||
| public Files.File source { get; construct; } | ||
| public Files.File destination { get; construct; } | ||
| public Files.File dest_dir { get; construct; } |
Member
There was a problem hiding this comment.
These should be private get, no?
Contributor
Author
There was a problem hiding this comment.
I thought construct properties had to be public get but maybe I'm wrong - I'll check. There's probably a lot of other instances with this pattern in my code!
Contributor
Author
There was a problem hiding this comment.
Seems you are right - I've learnt something, thanks. Now fixed.
Fix whitespace Co-authored-by: Leo <lenemter@gmail.com>
lenemter
approved these changes
Nov 7, 2025
lenemter
left a comment
lenemter
left a comment
Member
There was a problem hiding this comment.
Fixes the liked issue! Good job 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #695 (finally)