Do not eject before stopping drive#2204
Merged
Merged
Conversation
Contributor
Author
|
Closing as the Gtk3 version is being frozen. Will retarget to Gtk4 version |
Contributor
Author
|
Re-opening as freezing for Gtk4 port is not imminent. |
leonardo-lemos
approved these changes
Jun 8, 2025
Contributor
Author
|
I'll hold back until after v7.1.2 is released - probably tomorrow. There should be another release soon. |
jeremypw
added
Status: Blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2203
The issue was caused by ejecting the drive before stopping it. This PR just stops the drive if possible else ejects it.