fix: verify roll PR ownership in rollInfra#199
Merged
dsanders11 merged 1 commit intoJun 25, 2026
Conversation
rollInfra() looked up its own existing PR on electron/infra with an unqualified `head` value. GitHub's REST API expects `head` in `owner:ref-name` form, so the unqualified value did not filter and the request returned every open PR; the only remaining discriminator was the title prefix. Any open PR whose title started with `build: bump <subject>` was then treated as the roller's own PR, letting a third party suppress automated security rolls of CI runner images with a decoy PR. Owner-qualify the `head` filter so it only matches branches in the trusted electron/infra repo, and positively verify each candidate PR was authored by the roller App before treating it as our own. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WxGFj3ek5c1RTDgKVzYL3i
dsanders11
approved these changes
Jun 25, 2026
dsanders11
deleted the
claude/autopatch-scan-7a288aa7-vuln-1896358-7t677n
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rollInfra() looked up its own existing PR on electron/infra with an unqualified
headvalue. GitHub's REST API expectsheadinowner:ref-nameform, so the unqualified value did not filter and the request returned every open PR; the only remaining discriminator was the title prefix. Any open PR whose title started withbuild: bump <subject>was then treated as the roller's own PR, letting a third party suppress automated security rolls of CI runner images with a decoy PR.Owner-qualify the
headfilter so it only matches branches in the trusted electron/infra repo, and positively verify each candidate PR was authored by the roller App before treating it as our own.