Pydantic for settings template#2341
Closed
electro199 wants to merge 4 commits into
Closed
Conversation
Collaborator
|
pydantic is a great choice. Just want to wait a bit to merge this. Would like lewis's PR in first |
Contributor
Author
|
Sure meanwhile I can update whole project to use the Pydantic config object. What are you thoughts ? |
Contributor
|
This pull request is stale as it has been open for 7 days with no activity. Remove stale label or comment, or this will be closed in 10 days. |
Contributor
|
Pull request closed due to being stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use Pydantic for settings template and then in future use pydantic obj as config obj
Issue Fixes
Confusing templating with toml
Checklist:
Any other information (e.g how to test the changes)
None