Modernize esrally/utils/process.py#2147
Open
pquentin wants to merge 3 commits into
Open
Conversation
pquentin
added
cleanup
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes Rally’s subprocess helpers in esrally/utils/process.py by migrating legacy subprocess.call() / Popen() usage to subprocess.run() and replacing preexec_fn-based detaching with start_new_session.
Changes:
- Switch
run_subprocess()andrun_subprocess_with_output()tosubprocess.run(). - Replace
preexec_fn=os.setpgrpwithstart_new_session=detachfor detaching. - Simplify output capture by relying on
text=Trueand processingCompletedProcess.stdout.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
gbanasiak
requested review from
a team,
ebadyano and
gbanasiak
and removed request for
a team
gbanasiak
approved these changes
Jun 23, 2026
| env=env, | ||
| text=True, | ||
| encoding="utf-8", | ||
| check=False, |
Contributor
There was a problem hiding this comment.
nit: check=False is the default in subprocess.run(), so not required; same in other places.
Member
Author
There was a problem hiding this comment.
Yes, I wanted to be explicit, since it's not obvious to me that check=False is the default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next question is: why do we have four different ways to run subprocesses? Do we even need those helpers now that subprocess.run() exists?