Add track parameter validation hook#2144
Open
reugn wants to merge 3 commits into
Open
Conversation
gbanasiak
requested review from
gbanasiak and
pquentin
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks can already register custom param sources, runners, and schedulers, but there was no way to validate track parameters before a benchmark runs. This adds that missing hook.
register_validator(challenge_name, fn)so a track'sregister(registry)can register one or more validators for a challenge.TrackConfigErrorwhen they are invalid.BenchmarkCoordinator.setup(), after the track is loaded but before it provisions nodes or starts the benchmark, so bad parameters fail fast with a clear message.This change is additive and non-breaking. Tracks that do not register a validator behave exactly as before, since the hook is a no-op for them. No existing function signature changes in a way that affects current callers.
Closes #2143