Use esrally/race check= consistently in integration tests

[fressi-elastic]

This updates integration tests to rely on esrally / race with check=True by default instead of assert ... == 0, and uses check=False with CompletedProcess.returncode where the test needs a non-zero exit or an explicit success check.

Also fixes the pytest.fail message in it.esrally (f-string), handles TestCluster.stop via returncode, imports CompletedProcess, and expands docstrings for esrally and race without Sphinx roles in Python strings.

Made with Cursor

[Copilot]

Pull request overview

This pull request refactors the integration test helpers and test suite to run esrally / esrally race via wrappers that default to check=True, returning subprocess.CompletedProcess for cases where tests need to inspect output or assert non-zero exits.

Changes:

• Update it.esrally() / it.race() to return CompletedProcess, default to check=True, and improve failure messaging/docstrings.
• Replace many assert ... == 0 patterns in integration tests with wrapper calls that fail via check=True by default.
• Update selected tests that need non-zero exit assertions to use check=False and check returncode.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
it/init.py	Reworks esrally()/race() wrappers to return CompletedProcess, default check=True, and centralize subprocess execution.
it/tracker_test.py	Adopts new race() / esrally() invocation style for track creation and benchmarks.
it/static_responses_test.py	Switches race invocation to rely on wrapper check=True behavior.
it/sources_test.py	Switches race/build invocations to rely on wrapper check=True behavior.
it/proxy_test.py	Migrates subprocess execution to it.esrally(..., env=...) and asserts on captured stdout.
it/list_test.py	Removes explicit return-code assertions in favor of wrapper check=True.
it/info_test.py	Removes explicit return-code assertions in favor of wrapper check=True for success cases.
it/esrallyd_test.py	Uses check=False + returncode assertion for a race invocation prior to log assertions.
it/download_test.py	Uses wrapper for success cases and check=False + returncode for unsupported version case.
it/distribution_test.py	Uses wrapper for success cases and check=False + returncode where failure is expected.
it/dependencies_test.py	Switches race invocation to rely on wrapper check=True behavior.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[fressi-elastic]

Resolving Copilot review threads (explanation)

1. esrally_command_line_for — The helper was removed; the shell command is built only inside `it.esrally`. All former call sites use `it.esrally` / `it.race` or an explicit full command where subprocess needs a raw string (e.g. interrupt test). There are no remaining references to `esrally_command_line_for` on this branch.

2. shlex.join(err.args) — The failure path now uses `err.cmd` in the `pytest.fail` message instead of `shlex.join(err.args)`.

3. json.loads / `"".join(result.stdout)` — `TestCluster.install` now uses `json.loads(result.stdout)`.

4. tracker_test `check=False` — Simplified to `it.race(cfg, cmd)` with default `check=True` for consistent failure reporting.

5. esrallyd_test — Same: plain `it.race(...)` with default `check=True`, no redundant manual `returncode` check.