Add esrally race --prepare-only#2071
Open
fressi-elastic wants to merge 6 commits into
Open
Conversation
Add --prepare-only to stop after track preparation (and provisioning when applicable) without running the challenge or writing benchmark results. Skip persisting a partial race record in this mode. Shut down the driver and engine like a normal race end so --preserve-install semantics apply. Document the flag in race.rst and pipelines.rst; add unit tests for BenchmarkCoordinator preparation paths.
fressi-elastic
force-pushed
the
feature/race-prepare-only
branch
from
18740bf to
82c87b1
Compare
Contributor
Author
|
I tested it using regular Elasticsearch instance provisioning. I didn't tested with other pipelines, example: |
Contributor
Author
|
I tested it inside of a container with |
Prepare-only mode now prepares track data locally only: skip Elasticsearch clients and REST checks in the driver, seed distribution metadata from config or minimum ES version, use in-memory reporting, and avoid mechanic lifecycle when no engine is started. Race control sends Success directly when mechanic is absent; console messages use force/flush for quiet mode. Update race and pipeline docs to match (benchmark-only example uses distribution-version; no cluster stop messaging). Add integration tests and rally-prepare-only-it.ini; extend unit tests. Makefile: introduce PYTEST/DEBUG/PYTEST_FLAGS and route some IT targets through the test target.
- Default want_cluster_prepared to True and document subprocess roles. - Assert track repo and dataset cache exist under RALLY_HOME after prepare-only. - Assert prepare-only log skips engine and avoids mechanic provision paths. - Slice full-race log tail to assert Rally provisions ES vs benchmark-only external cluster. - Remove unused uuid import; fix comment spelling (artifacts).
- Import ES_METRICS_STORE at module scope and narrow http_port before waiting on cluster health (mypy arg-type, pylint import-outside-toplevel). - Annotate TestCluster.http_port as int | None and install http_port as int. - Drop useless pylint unused-argument suppression on configure_file_handler. Made-with: Cursor
fressi-elastic
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
--prepare-onlytoesrally raceso Rally can provision Elasticsearch (when the pipeline does), download and prepare track data under the Rally root, then exit successfully without running the challenge schedule or printing benchmark results.Behavior
--preserve-installand pipeline semantics still apply).race_store.store_raceduring preparation.