Remove node certs before creating new ones#112
Closed
NickDris wants to merge 1 commit into
Closed
Conversation
Member
|
Should we be trying to install over the top of an existing installation? |
Contributor
Author
Only after |
Member
|
I would say so yes, we should use a new installation id - im surprised we dont alert earlier though that the installation already exists |
Contributor
Author
|
We have decided to use another strategy for this. Rally users should be creating another build installation path, provided that different car params are used. This is cleaner and more efficient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During ES installation (
esrally install)elasticsearch-certutilwrites to{install_root}/node-cert.zip. If the installation path is preserved usingpreserve_elasticsearch_install=Truea secondesrally installwith car overrides results in "exit code 74: output file already exists"That is because
install_diralready exists with the oldnode-cert.zipfrom 1st benchmark.delete_pre_bundled_configuration()only deletes theconfig/subdirectory.elasticsearch-certutil cert --out="{install_root}/node-cert.zip"after the post installation hook results to file already exists → exit code 74.This was revealed when trying to execute sequential benchmark experiments with ES reinstallation using different cluster settings per experiment and preserve the elasticsearch directory during the benchmark executions.
Before that, I was running all experiments using identical install parameters, so the preserved installation was functionally fine.
This aims to clean the certs directory before extracting.