Conversation
biscout42
added this pull request to stack #384
September 17, 2026 10:30
biscout42
marked this pull request as ready for review
September 17, 2026 10:55
nicholasberlin
previously approved these changes
Sep 17, 2026
nicholasberlin
left a comment
nicholasberlin
left a comment
Contributor
There was a problem hiding this comment.
My bot had no issues, and neither do I.
pod.name matches the Kubernetes pod name of the process container and accepts the single * wildcard used by process.exe and file.path, as in pod.name nginx-*. container.image.name matches the image name of the process container exactly, the image name being the last path component of the image without registry and tag. Both fields walk the container link established by link_container_data, which already runs before the ruleset match. A process without a linked container, a container without a pod, or missing metadata matches neither. The nova backend rejects both with ENOTSUP like event.scope. The wildcard split in quark_rule_match_field is moved into wild_init so the three wildcard fields and the exact-match field share it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Rename the rule field to container.image. The field matches the image string that the runtime reports, with registry and tag. The field accepts one * wildcard, like the other string fields. Remove the strcmp match and the allow_star flag. Use path_match for all string fields. Create the test container through quark_container_create. Do not set image_name and do not link the process by hand in the test helper. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
biscout42
dismissed stale reviews from christos68k and nicholasberlin
via
September 21, 2026 08:32
0d3ab0d
biscout42
force-pushed
the
feat-rule-learns-podname-and-containerimage
branch
from
September 21, 2026 08:32
7feeecb to
0d3ab0d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.