Skip to content

Add functions to insert pods/containers to the new trees - #381

Open
Tacklebox wants to merge 3 commits into
oci-trees-structurefrom
oci-trees-c-api
Open

Tacklebox wants to merge 3 commits into
oci-trees-structurefrom
oci-trees-c-api

Conversation

@Tacklebox

@Tacklebox Tacklebox commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Add C functions to create pods and containers in the queue.
Copy the supplied values into each new object.
Permit optional fields to be NULL.
Permit containers without a pod.

Return NULL and set errno to EEXIST for a duplicate ID.
Return NULL and set errno to ESRCH if the requested pod is missing.

Address the code review comments.
Print <unknown> for missing pod and container fields in event output.
Add creation, lookup, and error tests.
Add event output tests for missing fields and supplied values.

The Docker build passed with make ARCH=arm64 docker.
All six pod and container tests passed on Linux.
The diff check passed.
The Kubernetes integration test was not run.

Stack created with GitHub Stacks CLIGive Feedback 💬

@biscout42 biscout42 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main ask if we have unit tests or could we add them?

Comment thread quark.c
Comment thread quark.c
Comment thread quark.c
Comment thread quark.c
Comment thread quark.c
@biscout42
biscout42 force-pushed the oci-trees-c-api branch 3 times, most recently from 9a391e5 to 0904516 Compare September 16, 2026 12:12
biscout42 added a commit that referenced this pull request Sep 16, 2026
Print <unknown> for missing pod and container fields.
Add pod and container creation tests.
Add tests for missing fields in event output.

The Docker build passed.
All six pod and container tests passed on Linux.
@biscout42
biscout42 marked this pull request as ready for review September 16, 2026 12:48
@biscout42
biscout42 requested a review from a team as a code owner September 16, 2026 12:48
biscout42
biscout42 previously approved these changes Sep 16, 2026
@biscout42
biscout42 force-pushed the oci-trees-c-api branch 3 times, most recently from 3ddc5df to c3e0bf2 Compare September 24, 2026 11:29
Tacklebox and others added 3 commits September 24, 2026 13:57
Print <unknown> for missing pod and container fields.
Add pod and container creation tests.
Add tests for missing fields in event output.

The Docker build passed.
All six pod and container tests passed on Linux.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants