[fbreceiver] Ignore cgo DNS goroutines in goleak leak checker on macOS#52140
Draft
macdewee wants to merge 2 commits into
Draft
[fbreceiver] Ignore cgo DNS goroutines in goleak leak checker on macOS#52140macdewee wants to merge 2 commits into
macdewee wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This pull request doesn't have a |
Contributor
🤖 GitHub commentsJust comment with:
|
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
WHAT: Add
goleak.IgnoreAnyFunction("net.cgoResSearch")to the skip list inoteltest.VerifyNoLeaks. This is the same pattern already used fornet.(*netFD).connectandnet/http.(*Transport).startDialConnForLocked.WHY:
TestLeak,TestNewReceiver, andTestMultipleReceiversinx-pack/filebeat/fbreceiverfail intermittently onmacos-15-intelCI runners. The goroutine leak checker detects a goroutine stuck for ~1 minute in a cgo DNSres_nsearchsyscall (net.cgoResSearch→syscall.syscalln). This is a networking/infrastructure issue on the runner where a DNS lookup issued during the test never returns — not a real leak in production code. The filter is narrow and targets only that specific cgo DNS frame.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature works.(test infrastructure change; the leak only manifests on macOS CI)I have added an entry in(test-only change)./changelog/fragmentsusing the changelog tool.Disruptive User Impact
None. Test infrastructure change only.
How to test this PR locally
The DNS hang only occurs on restricted macOS CI networking and is not reliably reproducible locally. Verify that the existing
fbreceivertests still pass:Related issues
Logs