chore: align d3 sub-packages with d3@7 peer dep#43
Merged
Conversation
The peer dep declares d3@^7.0.0, but the direct d3-* sub-package deps were pinned to v2-era versions. d3@7 bundles v3/v4 of these packages, so consumers installing cubism-es + d3@7 get both copies in their tree — duplicate bundle weight plus potential behavioral divergence (d3-selection v2→v3 removed d3.event). The source already uses the v3 event pattern ((event) => pointer(...) with no d3.event access), so this is pure dep alignment. d3-axis, d3-dispatch, d3-fetch, d3-format, d3-selection, d3-time: 2 → 3 d3-time-format: 3 → 4 These match the versions d3@7 itself depends on.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 33 33
Lines 883 883
Branches 193 194 +1
=======================================
Hits 879 879
Misses 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
peerDependenciesdeclaresd3: ^7.0.0, but the directd3-*sub-package deps are pinned to v2-era versions. d3@7 bundles v3/v4 of these, so consumers installingcubism-es+d3@7get both copies in their dependency tree:d3-axis,d3-dispatch,d3-fetch,d3-format,d3-selection,d3-timed3-time-formatThe source already uses the v3 event pattern (
(event) => pointer(event, ...)— nod3.eventanywhere), so this is pure dep alignment, no code changes. Lockfile net −115 lines.92 tests pass on the upstream tree.