Skip to content

Add Proposal Link Popovers#13

Open
ritorhymes wants to merge 3 commits into
eips-wg:masterfrom
ritovision:feature/proposal-link-popovers
Open

Add Proposal Link Popovers#13
ritorhymes wants to merge 3 commits into
eips-wg:masterfrom
ritovision:feature/proposal-link-popovers

Conversation

@ritorhymes

@ritorhymes ritorhymes commented May 7, 2026

Copy link
Copy Markdown

Depends on the generated assets/data/proposals.json produced by the companion preprocessor PR eips-wg/preprocessor/pull/34. That preprocessor work is built on top of the V2 multi-repo local build stack tracked in eips-wg/preprocessor#15.

Summary

This adds hover and keyboard-focus previews / popovers for EIP/ERC proposal links, showing the proposal number, title, description, status, type, and category when available.

Demo site: wg-eips.ritovision.com

  • Add proposal metadata popovers to proposal links inside page content.
  • Lazy-load generated proposal metadata from assets/data/proposals.json.
  • Recognize local proposal links, explicit /EIPS/eip-N and /ERCS/erc-N routes, public proposal hosts, query/fragment variants, and base-path deployments.
  • Build popover content with DOM text APIs to avoid rendering contributor-controlled fields as HTML.
  • Use Bootstrap Popover manually after metadata loads.
  • Disable popovers on touch/coarse-pointer devices while preserving desktop hover and keyboard focus behavior.
  • Skip same-page proposal links so table-of-contents/current-page links do not show redundant previews.
  • Fail softly when generated metadata is absent, invalid, or unsupported.

Closes #2

Verification:

  • zola build
  • Browser smoke test with generated proposals.json
  • Touch-device/long-press smoke test

ritorhymes added 3 commits May 5, 2026 03:22
Render external requires entries as direct links without forcing Zola to
resolve them as local pages.

This supports targeted --only rendering, where cross-repo proposal
dependencies can be rewritten to external URLs instead of local pages.

Move the theme demo homepage badges into front matter, a homepage_badges
macro, and theme-owned styles so the demo homepage stays
markdown-friendly.

Declare Zola 0.22.1 as the minimum supported version, enable bottom
footnotes, and update markdown highlighting to the class-based config
with github-light/dark themes and ABNF/CSL-JSON grammars.
Add POSIX and PowerShell setup scripts for theme contributors that
reuse or install build-eips, ensure a supported Zola is available, and
bootstrap the surrounding workspace through an active proposal repo.

Document the theme local development workflow, including workspace
layout, setup flags, serve versus preview, server/base URL settings,
targeted rendering, and source/output overrides.

Keep this focused on setup and documentation; theme rendering behavior
continues to be owned by the earlier theme PR.
Load generated proposal metadata lazily from the URL injected by
base.html, leaving theme-only builds to fail softly when the file is
absent.

Recognize local, explicit EIPS/ERCS, public host, query/fragment, and
base-path proposal link forms before resolving records by stable metadata
keys or active-prefix number fallback.

Attach manual Bootstrap popovers after metadata loads, using safe DOM text
construction for contributor-controlled fields and viewport-aware Popper
placement for hover and keyboard focus interactions.

Skip same-page proposal links and disable popovers on touch/coarse-pointer
devices while keeping desktop hover and keyboard focus behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display a tooltip when hovering over an EIP/ERC link

1 participant