Skip to content

Add themed 404 page #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ritorhymes wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add themed 404 page #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions sass/assets/css/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,22 @@ pre,code {
background-color: initial;
}

.not-found-page {
display: flex;
align-items: center;
min-height: 60vh;
}

.not-found-page .post {
width: 100%;
}

.not-found-code {
font-size: 50px;
line-height: 1;
margin-bottom: 0.75rem;
}

.eiptable .title {
width: 67%;
}
Expand Down
39 changes: 39 additions & 0 deletions templates/404.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
{% extends "base.html" %}

{% block title -%}
404 Not Found | {{ config.title -}}
{% endblock title %}

{% block extra_head %}
<meta property="og:title" content="404 Not Found | {{ config.title }}" />
<meta property="og:type" content="website" />
<script type="application/ld+json">
{
"@type": "WebPage",
"url": "{{ get_url(path='/404.html', trailing_slash=false) | safe }}",
"name": "404 Not Found | {{ config.title }}",
"description": "{{ config.description }}",
"@context": "https://schema.org"
}
</script>
{% endblock extra_head %}

{% block content %}
<section class="not-found-page" aria-labelledby="not-found-title">
<article class="post">
<header class="post-header">
<p class="post-meta not-found-code">404</p>
<h1 class="post-title" id="not-found-title">Page not found</h1>
</header>
<div class="post-content">
<p>The page you requested does not exist or may have moved.</p>
<p>You can return to the homepage, browse proposal lists, or use search to find the document you need.</p>
<p>
<a href="{{ get_url(path='/', trailing_slash=false) }}">Return home</a>
<span aria-hidden="true"> · </span>
<a href="{{ get_url(path='/status/', trailing_slash=false) }}">Browse proposals</a>
</p>
</div>
</article>
</section>
{% endblock content %}
2 changes: 2 additions & 0 deletions templates/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
<link rel="apple-touch-icon" href="/assets/images/apple-touch-icon.png" />

<meta property="og:site_name" content="{{ config.title }}" />
{% if current_url %}
<link property="og:url" href="{{ current_url }}" />
{% endif %}

{% block extra_head %}
<meta property="og:title" content="{{ config.title }}" />
Expand Down