This repository was archived by the owner on Sep 10, 2026. It is now read-only.
Repository navigation
Release: version packages - #61
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@eigeninteractive/server@0.4.0
Minor Changes
#60
4339dffThanks @seenu-k! - Pagination cursors are now opaque tokens, and empty query parameters are treated as absent.Every paged list could silently return nothing. A client that sent an optional
query parameter it had no value for produced
?cursor, which arrives as theempty string, and
z.coerce.number()isNumber(), so""became0. Zero isa structurally valid integer cursor meaning "strictly older than the beginning of
time", so the request did not fail: the lobby, both
games/minebuckets, thefriends list and every history screen returned
200with an empty array. Nothingwas logged, because nothing had gone wrong as far as any layer could tell.
Three changes, each closing a different part of it:
cursoris now an opaque string rather than a bare epoch-millisecondinteger, and paged responses carry a
nextCursorthat is null exactly whenthe list is exhausted. There is no byte string that accidentally decodes to the
beginning of time, so the failure above cannot recur by construction. A cursor
that does not decode is a
400with the newinvalidCursorcode.The cursor carries the row id alongside the sort value, so pages no longer
drop a row when two games share a timestamp - a limitation the previous
implementation documented but did not fix. The comparison is a SQLite row value
(
(sortKey, id) < (?, ?)), which is planned against the same index.Query parameters are parsed, never coerced. This is the origin of the whole
failure, and it took four correct layers to become invisible.
Number(null)is0, soz.coerce.number().int().min(0)genuinely accepts null; the emittedschema honestly reported
["integer", "null"];openapi-generatorcorrectlydropped its
if (x != null)guard, because the API had declared null welcome;dio rendered that null as a bare
?to=; and the server coerced""back to0. No library was misbehaving. Integer query parameters now parse from astrict pattern, so they reject null and empty alike, which means the generated
client omits an absent parameter on its own and a malformed one is a loud
400rather than a plausible, wrong
200.?pool=and?to=were failing the sameway and are fixed by the same change.
A contract test now asserts that no query parameter in the published document
is nullable, which is the tell that was invisible in review:
.min(0)wasnullable and
.min(1)was not.Because
nextCursoris now an answer rather than something a client infers froma short page, callers no longer need to know how any list is sorted, and a final
page that happens to be exactly full no longer triggers one pointless request.
Breaking for direct API consumers:
cursoris a string, and the four pagedresponses (
Lobby,MyGames,PlayerGames,FriendsGames) gained a requirednextCursorfield. The generated Dart client andeigen_flutterare updated tomatch.
Patch Changes
@eigeninteractive/kernel@0.4.0
Patch Changes
@eigeninteractive/testkit@0.4.0
Patch Changes
@eigeninteractive/rules@0.4.0