This repository was archived by the owner on Sep 10, 2026. It is now read-only.
Name the rule that governs how the two config files are edited - #36
Merged
Merged
Conversation
Both destinations already declare the key being filled, so this assigns into a slot rather than appending anything, and the two are edited by different methods for one reason: `app-config.json` is plain JSON and can be decoded, merged and re-encoded, while `wrangler.jsonc` carries comments its owner wrote, so only the single assignment is rewritten in place. `setJsonString` already explained its own half; the library docstring now states the split and points at the wider doctrine in eigen-server's MAINTAINERS.md. Comments only. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments only — no behavioural change.
linkFirebaseProjectwrites into two files, by two different methods, and until now nothing said why at library level:app-config.jsonwrangler.jsoncsetJsonStringalready explained its own half well, including that the safety is the match count rather than the pattern. What was missing was the contrast, and the fact that both destinations already declare the key being filled — so this assigns into a slot rather than appending anything, which is the distinction that keeps it from drifting toward block insertion.The library docstring now states that and points at the wider doctrine, which lands alongside in eigeninteractive/eigen-server#58: append never insert, why a content probe rather than marker comments identifies a written block, and why FlutterFire's
// START:/// END:markers are deliberately not copied.dart analyzeclean;dart doc --dry-run .reports 0 warnings and 0 errors, which is the check that matters here since this repo promotes unresolved references to errors and the new text adds a[setJsonString]reference.🤖 Generated with Claude Code